Add missing requirements.txt and venvs for Python tutorials
#563
Conversation
There was a problem hiding this comment.
I have not tried to run or check if each requirements.txt included all and the correct dependencies, but the changes look good.
Thanks also for catching and fixing some small inconsistencies (e.g., forgotten close_log, or initializing the venv before starting to log)!
There was a problem hiding this comment.
Thank you for the PR! This really gives a very good overview of the current state and where we have to clarify some questions. I added some comments to point to the open issues. I will briefly summarize here:
- Generally restrict numpy.
- Is
mpi4pyactually afenicsprecicedependency? Move it there? - If
pypreciceis afenicsprecicedependency move it there - Find a good approach for FEniCS
I would suggest to merge #564 and #557 independently from this PR because I expect that we are quicker with these smaller PRs.
flow-around-controlled-moving-cylinder/solid-python/requirements.txt
Outdated
Show resolved
Hide resolved
I saw that |
Adds the missing
requirements.txtfiles mentioned in #547 and modifies the run scripts accordingly.I followed the approach suggested here: #547 (comment) to prevent redundant requirement files.
This concerns the following tutorials: